Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update k8s version to 1.30 #3748

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nikoshet
Copy link

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@nikoshet nikoshet force-pushed the chore/bump-k8s-version-to-1.30 branch 7 times, most recently from 6ee7b62 to a548264 Compare July 25, 2024 14:49
Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.95%. Comparing base (0397210) to head (870c629).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3748      +/-   ##
==========================================
- Coverage   83.96%   83.95%   -0.02%     
==========================================
  Files         162      162              
  Lines       18508    18508              
==========================================
- Hits        15540    15538       -2     
- Misses       2106     2107       +1     
- Partials      862      863       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jul 25, 2024

Published E2E Test Results

  4 files    4 suites   3h 18m 54s ⏱️
112 tests 101 ✅  7 💤 4 ❌
452 runs  420 ✅ 28 💤 4 ❌

For more details on these failures, see this check.

Results for commit 870c629.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jul 25, 2024

Published Unit Test Results

2 257 tests   2 257 ✅  2m 59s ⏱️
  128 suites      0 💤
    1 files        0 ❌

Results for commit 870c629.

♻️ This comment has been updated with latest results.

@zachaller zachaller force-pushed the chore/bump-k8s-version-to-1.30 branch from a548264 to 217c733 Compare July 29, 2024 20:42
@argoproj argoproj deleted a comment from github-actions bot Aug 1, 2024
@zachaller
Copy link
Collaborator

We should remove on on the tail end like 1.26.

nikoshet and others added 2 commits August 13, 2024 19:31
Signed-off-by: Zach Aller <[email protected]>
@zachaller zachaller force-pushed the chore/bump-k8s-version-to-1.30 branch from 5f7f06e to 870c629 Compare August 13, 2024 17:31
Copy link

sonarcloud bot commented Aug 13, 2024

@mansing2
Copy link

mansing2 commented Oct 9, 2024

Any plan in near future to support K8S v1.30. We want to upgrade the k8s and we are blocked.

@zachaller
Copy link
Collaborator

@mansing2 I would not let what clients Rollouts uses cause you to not upgrade your k8s cluster. As long as you do not use any of the new pod spec fields if there are any it will be ok we use very little k8s feature set. The only big one being the embedded pod spec into the rollout resource.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants