fix(side-navbar): keyboard a11y

replace div with button to allow activation using space and enter
argoproj · May 20, 2022 · 14f8b22 · 14f8b22
1 parent 1e23727
commit 14f8b22
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/components/nav-bar/nav-bar.scss b/src/components/nav-bar/nav-bar.scss
@@ -105,5 +105,9 @@ $nav-break-height-sm: 746px;
     .nav-bar__item {
         margin: 10px 0;
         font-size: 25px;
+        font-family: inherit;
+        line-height: 1.5;
+        display: block;
+        width: 100%;
     }
 }
diff --git a/src/components/nav-bar/nav-bar.tsx b/src/components/nav-bar/nav-bar.tsx
@@ -35,10 +35,10 @@ export const NavBar: React.FunctionComponent<NavBarProps> = (props: NavBarProps,
                 <div className='nav-bar__version'>{props.version && props.version()}</div>
                 {(props.items || []).map((item) => (
                     <Tooltip content={item.title} placement='right' arrow={true} key={item.path + item.title}>
-                        <div className={classNames('nav-bar__item', { active: isActiveRoute(locationPath, item.path) })}
+                        <button type="button" className={classNames('nav-bar__item', { active: isActiveRoute(locationPath, item.path) })}
                             onClick={() => context.router.history.push(item.path)}>
                             <i className={item.iconClassName}/>
-                        </div>
+                        </button>
                     </Tooltip>
                 ))}
             </div>