feat(autocomplete): make autoHighlight configurable. Fixes #559 (#560)

* fix: remove autoHighlight on autocomplete by default Signed-off-by: Adrien Delannoy <[email protected]> * update default to `true` with a comment about upstream Signed-off-by: Anton Gilgur <[email protected]> --------- Signed-off-by: Adrien Delannoy <[email protected]> Signed-off-by: Anton Gilgur <[email protected]> Co-authored-by: Anton Gilgur <[email protected]>
argoproj · Jun 8, 2024 · 2c503a8 · 2c503a8
1 parent 4f102b1
commit 2c503a8
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/components/autocomplete/autocomplete.tsx b/src/components/autocomplete/autocomplete.tsx
@@ -25,6 +25,7 @@ export interface AutocompleteProps {
     autoCompleteRef?: (api: AutocompleteApi) => any;
     filterSuggestions?: boolean;
     qeid?: string;
+    autoHighlight?: true; // ReactAutocomplete.Props['autoHighlight'] is missing the `true` default per https://github.com/argoproj/argo-ui/pull/560#issuecomment-2155872347
 }
 
 export const Autocomplete = (props: AutocompleteProps) => {
@@ -57,7 +58,7 @@ export const Autocomplete = (props: AutocompleteProps) => {
     wrapperProps.className = classNames('select', wrapperProps.className);
     return (
         <ReactAutocomplete
-            autoHighlight={true}
+            autoHighlight={props.autoHighlight}
             ref={(el: any) => {
                 if (el) {
                     if (el.refs.input) {