change: from div to react link component (#12813)

argoproj · Nov 5, 2024 · b63f891 · b63f891
1 parent 09a98cb
commit b63f891
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/components/nav-bar/nav-bar.tsx b/src/components/nav-bar/nav-bar.tsx
@@ -1,6 +1,7 @@
 import {default as classNames} from 'classnames';
 import * as PropTypes from 'prop-types';
 import * as React from 'react';
+import {Link} from 'react-router-dom'; // Import Link component
 
 import { AppContext } from '../../context';
 import {Tooltip} from '../tooltip/tooltip';
@@ -35,10 +36,9 @@ export const NavBar: React.FunctionComponent<NavBarProps> = (props: NavBarProps,
                 <div className='nav-bar__version'>{props.version && props.version()}</div>
                 {(props.items || []).map((item) => (
                     <Tooltip content={item.title} placement='right' arrow={true} key={item.path + item.title}>
-                        <div className={classNames('nav-bar__item', { active: isActiveRoute(locationPath, item.path) })}
-                            onClick={() => context.router.history.push(item.path)} role="checkbox">
-                            <i className={item.iconClassName}/>
-                        </div>
+                        <Link to={item.path} className={classNames('nav-bar__item', { active: isActiveRoute(locationPath, item.path) })}>
+                            <i className={item.iconClassName} />
+                        </Link>
                     </Tooltip>
                 ))}
             </div>