-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace custom components with antd
components
#553
Comments
Oh this might not be correct actually. It's only used in Huh, I guess Workflows might not use
I think that also means that these two UI libraries don't actually overlap? We are using |
Indeed there aren't even any components in Apparently it was supposed to be used in v2: #161 (review), but that never happened (been 2.5 years since then now 😕) Given that it's all unused code and unused deps, and complicates the build unnecessarily (another Storybook build, Less and Gulp usage for some reason, etc), and given the state of this repo per #453, I'm actually pretty inclined to remove it entirely. What we may want to do in the future, per #453, is to switch all Argoproj UIs to use CD and Workflows don't use |
Closing as unplanned due to deprecation |
Motivation
Reduce the scope of this component library, reduce its bundle size, use more tooling from the UI libraries we import, and have more consistent styling with that UI library. Should help with #453
We already use
antd
, let's use its components everywhere instead of having custom components in some places. At the very least, if we need custom functionality, we can wrap theantd
components.Also would be good to remove
foundation-sites
since that's another (dated) UI library and standardize onantd
Use Cases
A few components that can be replaced from a quick glance:
Popup
-> Popover / Popconfirm / Modal / AlertSlidingPanel
-> DrawerProbably several others too
The text was updated successfully, but these errors were encountered: