chore(deps): remove unused antd directory and deps
#554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agilgur5
added
type/dependencies
agilgur5
requested review from
crenshaw-dev,
terrytangyuan,
rbreeze and
isubasinghe
- there are no components, only stories in the `./antd` dir
- and doubly confirmed that none of these are used in CD, Workflows, or Rollouts
- so remove the `./antd` dir entirely as well as all related deps
- `antd` ofc, but also all the `less` deps and the `gulp` build for `antd`'s styles
- I'm not even sure what the `gulp` build was for exactly, nor why it used different tooling than already existed in this repo
Signed-off-by: Anton Gilgur <[email protected]>
agilgur5
force-pushed
the
chore-deps-remove-unused-antd
branch
from
43f043d
to
4ece459
Compare
|
Fixed merge conflict with #534 |
isubasinghe
approved these changes
May 28, 2024
crenshaw-dev
approved these changes
Jun 7, 2024
Signed-off-by: Anton Gilgur <[email protected]>
|
Fixed a tiny merge conflict in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #553 (comment) and #453 (comment), remove the unused
antddir and depsantdwas seemingly meant to be used inv2per Antd redesign #161 (review), but that never happened.argo-ui: future state of this repo #453 this repo is effectively deprecated & unmaintained. Moving forward, Argoproj UIs should useantddirectly instead ofargo-ui, as Rollouts is doing in some placesMotivation
./antddirModifications
./antddir entirely as well as all related depsantdofc, but also all thelessdeps and thegulpbuild forantd's stylesgulpbuild was for exactly, nor why it used different tooling than already existed in this repoVerification
The removed files etc are entirely unused