Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fonts to include correct Helm icon #363

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

tongpu
Copy link
Contributor

@tongpu tongpu commented May 2, 2023

This is a follow-up to #287 in which I updated the Helm icon, but did not update the font files.

Fixes #286

@tongpu
Copy link
Contributor Author

tongpu commented May 2, 2023

@saumeya @rbreeze This is a follow-up for my previous PR, because I didn't know how to update the font files. This should now fix the Helm icon in the UI.

@github-actions
Copy link

github-actions bot commented Jul 1, 2023

Stale pull request message

@github-actions github-actions bot added the problem/stale This has not had a response in some time label Jul 1, 2023
@tongpu
Copy link
Contributor Author

tongpu commented Jul 2, 2023

@saumeya @rbreeze Would you be able to review this and include the changes?

@github-actions github-actions bot removed the problem/stale This has not had a response in some time label Jul 2, 2023
This is a follow-up to argoproj#287

Signed-off-by: Lukas Grossar <[email protected]>
@agilgur5
Copy link
Contributor

agilgur5 commented Aug 23, 2023

Asking @rbreeze over CNCF Slack if he could review this. I'm not an approver as of this time, so I can't merge things.

Thanks for your efforts in fixing this again!

Copy link
Member

@rbreeze rbreeze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rbreeze rbreeze merged commit 76fa7c1 into argoproj:master Sep 13, 2023
3 checks passed
@tongpu tongpu deleted the chore/update_fonts branch September 15, 2023 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm icon is not being rendered correctly
3 participants