Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): upgrade to node v20 #536

Merged
merged 1 commit into from
Jun 3, 2024

Commits on Feb 14, 2024

  1. chore(deps): upgrade to node v20

    - node v14 is EoL and has been [since April 2023](https://github.com/nodejs/Release/blob/68840fae8fdaa59bf9431661238dbb86b4390829/README.md?plain=1#L7)
    - node v20 is the [current LTS version](https://github.com/nodejs/Release/blob/9cf9c6ed8178e88c74dfa1921a793701e1d162c4/README.md?plain=1#L8)
    
    - due to an old version of Storybook / Webpack, we have to run all Storybook scripts with `NODE_OPTIONS='--openssl-legacy-provider'`
      - this must be used if we use newer versions of node without upgrading Storybook + Webpack
        - unfortunately, upgrading Storybook is significantly easier said than done, especially since there are 3 different Storybook builds in this repo (v1, v2, and `antd`)
          - so put that off for now (or ever? since this repo is not maintained much anymore)
      - note that this is an insecure run-time configuration (which is why it was deprecated and is legacy), but since it is only used in development, it's not a significant vulnerability
    
    Signed-off-by: Anton Gilgur <[email protected]>
    agilgur5 committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    669bef4 View commit details
    Browse the repository at this point in the history