feat(popup): styles for list element in popup #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandre Gaudreault <[email protected]>
14 tasks
agilgur5
approved these changes
May 13, 2024
There was a problem hiding this comment.
LGTM off hand, tiny refactor and tiny addition.
Per argoproj/argo-cd#18116 (comment), it sounds like we might want to apply some of these styles on all children, instead of specific ones, but that can be a future improvement.
I'll let CD folks double-check.
agilgur5
changed the title
ishitasequeira
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Necessary for argoproj/argo-cd#18116