Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: popup header icon top alignment #575

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

Gaic4o
Copy link
Contributor

@Gaic4o Gaic4o commented Aug 5, 2024

Motivation

Misalignment of Close Button in Delete Application Modal

스크린샷 2024-08-05 오전 12 14 08

In the Argo-CD project, there is an issue where the Title and close icon close parts of the Popup Header are misaligned. To solve this, I modified the style code.

Modifications:

We modified the top style code in the popup Header i tag in the popup component style code.

@agilgur5 agilgur5 changed the title style: popup header i top code modification style: popup header icon top alignment Aug 22, 2024
@agilgur5 agilgur5 changed the title style: popup header icon top alignment fix: popup header icon top alignment Aug 29, 2024
Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, lgtm. Thanks!

@crenshaw-dev crenshaw-dev enabled auto-merge (squash) October 11, 2024 23:01
@crenshaw-dev crenshaw-dev merged commit 54f36c7 into argoproj:master Oct 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants