fix!: remove deprecated durationMs prop
#577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- I previously left in `durationMs` for backward-compatibility so that you could use either, but I forgot to mark the types as optional, so both ended up being required by the typings - instead of making them both confusingly optional (no way of doing "one of"), just remove the deprecated `durationMs` in another breaking change Signed-off-by: Anton Gilgur <[email protected]>
agilgur5
force-pushed
the
fix-durationS-optional
branch
from
c884140
to
0a0ec11
Compare
8 tasks
ashutosh16
approved these changes
Aug 29, 2024
alexmt
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #535 (comment), fixes the issue I discovered in argoproj/argo-cd#19655 (comment)
Motivation
I previously left in
durationMsfor backward-compatibility so that you could use either, but I forgot to mark the types as optional, so both ended up being required by the typings, oops 🙃Modifications
Instead of making them both confusingly optional (no way of doing "one of"), just remove the deprecated
durationMsin another breaking change