fix: validate template of the same name. Fixes #13763 #14043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tianchu Zhao <[email protected]>
|
/retest |
1 similar comment
|
/retest |
MasonM
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13763
Motivation
Validate template even if they use the same name (happened in nested template situation).
So that all templates are validated and cached in
storedTemplateupon workflow submissionModifications
Include templateScope in validation cache,
so that the validation is aware which
workflowTemplateis the currenttemplatecoming from, andtemplateof the same name from differentworkflowTemplatewill not skip validationVerification
Added unit test, test failed
Added code change, unit test passed