-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: sync with apps-of-apps (#32) #35
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Alexandre Gaudreault <[email protected]>
Signed-off-by: Alexandre Gaudreault <[email protected]>
argoproj/base/argo-cd.yaml
Outdated
### Just as a prevention, we do not want ArgoCD to self delete | ||
# finalizers: | ||
# - resources-finalizer.argocd.argoproj.io |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Meant to still be commented out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I though that leaving the config commented out with the explanation on top was I good idea, this way people that look at the apps aren't asking themselves why is there no finalizer to this app or why isn't the sync enabled? was it on purpose or someone forgot?
Since it is a demo setup, I think it is interesting to explicitly explain why it is commented.
ditto for all commented sections in Apps.
What do you think?
Signed-off-by: Alexandre Gaudreault <[email protected]>
Closes #32
Note: The 2 new apps are already applied in the cluster