Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sync with apps-of-apps (#32) #35

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

agaudreault
Copy link
Member

@agaudreault agaudreault commented Mar 7, 2024

Closes #32

Note: The 2 new apps are already applied in the cluster

Signed-off-by: Alexandre Gaudreault <[email protected]>
Signed-off-by: Alexandre Gaudreault <[email protected]>
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
argocd/base/sync-project.yaml Outdated Show resolved Hide resolved
Comment on lines 6 to 8
### Just as a prevention, we do not want ArgoCD to self delete
# finalizers:
# - resources-finalizer.argocd.argoproj.io
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meant to still be commented out?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I though that leaving the config commented out with the explanation on top was I good idea, this way people that look at the apps aren't asking themselves why is there no finalizer to this app or why isn't the sync enabled? was it on purpose or someone forgot?

Since it is a demo setup, I think it is interesting to explicitly explain why it is commented.

ditto for all commented sections in Apps.

What do you think?

argoproj/base/cert-manager.yaml Show resolved Hide resolved
argoproj/base/external-dns.yaml Show resolved Hide resolved
argoproj/base/ingress-nginx.yaml Show resolved Hide resolved
Signed-off-by: Alexandre Gaudreault <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Apps-of-Apps pattern to manage cluster
2 participants