chore: enable typeDefFirst rule from go-critic

Signed-off-by: Matthieu MOREL <[email protected]>

Author: mmorel-35

.golangci.yaml

@@ -26,7 +26,6 @@ linters:
         - importShadow
         - paramTypeCombine
         - rangeValCopy
-        - typeDefFirst
         - unnamedResult
         - whyNoLint
       enable-all: true

pkg/sync/sync_context.go

@@ -57,6 +57,57 @@ type SyncContext interface {
 	GetState() (common.OperationPhase, string, []common.ResourceSyncResult)
 }
 
+type syncContext struct {
+	healthOverride      health.HealthOverride
+	permissionValidator common.PermissionValidator
+	resources           map[kubeutil.ResourceKey]reconciledResource
+	hooks               []*unstructured.Unstructured
+	config              *rest.Config
+	rawConfig           *rest.Config
+	dynamicIf           dynamic.Interface
+	disco               discovery.DiscoveryInterface
+	extensionsclientset *clientset.Clientset
+	kubectl             kubeutil.Kubectl
+	resourceOps         kubeutil.ResourceOperations
+	namespace           string
+
+	dryRun                          bool
+	skipDryRunOnMissingResource     bool
+	force                           bool
+	validate                        bool
+	skipHooks                       bool
+	resourcesFilter                 func(key kubeutil.ResourceKey, target *unstructured.Unstructured, live *unstructured.Unstructured) bool
+	prune                           bool
+	replace                         bool
+	serverSideApply                 bool
+	serverSideApplyManager          string
+	pruneLast                       bool
+	prunePropagationPolicy          *metav1.DeletionPropagation
+	pruneConfirmed                  bool
+	clientSideApplyMigrationManager string
+	enableClientSideApplyMigration  bool
+
+	syncRes   map[string]common.ResourceSyncResult
+	startedAt time.Time
+	revision  string
+	phase     common.OperationPhase
+	message   string
+
+	log logr.Logger
+	// lock to protect concurrent updates of the result list
+	lock sync.Mutex
+
+	// syncNamespace is a function that will determine if the managed
+	// namespace should be synced
+	syncNamespace func(*unstructured.Unstructured, *unstructured.Unstructured) (bool, error)
+
+	syncWaveHook common.SyncWaveHook
+
+	applyOutOfSyncOnly bool
+	// stores whether the resource is modified or not
+	modificationResult map[kubeutil.ResourceKey]bool
+}
+
 // SyncOpt is a callback that update sync operation settings
 type SyncOpt func(ctx *syncContext)
 
@@ -340,57 +391,6 @@ func (sc *syncContext) getOperationPhase(obj *unstructured.Unstructured) (common
 	return phase, message, nil
 }
 
-type syncContext struct {
-	healthOverride      health.HealthOverride
-	permissionValidator common.PermissionValidator
-	resources           map[kubeutil.ResourceKey]reconciledResource
-	hooks               []*unstructured.Unstructured
-	config              *rest.Config
-	rawConfig           *rest.Config
-	dynamicIf           dynamic.Interface
-	disco               discovery.DiscoveryInterface
-	extensionsclientset *clientset.Clientset
-	kubectl             kubeutil.Kubectl
-	resourceOps         kubeutil.ResourceOperations
-	namespace           string
-
-	dryRun                          bool
-	skipDryRunOnMissingResource     bool
-	force                           bool
-	validate                        bool
-	skipHooks                       bool
-	resourcesFilter                 func(key kubeutil.ResourceKey, target *unstructured.Unstructured, live *unstructured.Unstructured) bool
-	prune                           bool
-	replace                         bool
-	serverSideApply                 bool
-	serverSideApplyManager          string
-	pruneLast                       bool
-	prunePropagationPolicy          *metav1.DeletionPropagation
-	pruneConfirmed                  bool
-	clientSideApplyMigrationManager string
-	enableClientSideApplyMigration  bool
-
-	syncRes   map[string]common.ResourceSyncResult
-	startedAt time.Time
-	revision  string
-	phase     common.OperationPhase
-	message   string
-
-	log logr.Logger
-	// lock to protect concurrent updates of the result list
-	lock sync.Mutex
-
-	// syncNamespace is a function that will determine if the managed
-	// namespace should be synced
-	syncNamespace func(*unstructured.Unstructured, *unstructured.Unstructured) (bool, error)
-
-	syncWaveHook common.SyncWaveHook
-
-	applyOutOfSyncOnly bool
-	// stores whether the resource is modified or not
-	modificationResult map[kubeutil.ResourceKey]bool
-}
-
 func (sc *syncContext) setRunningPhase(tasks []*syncTask, isPendingDeletion bool) {
 	if len(tasks) > 0 {
 		firstTask := tasks[0]