This repository was archived by the owner on Nov 8, 2025. It is now read-only.
feat: add ExternalSecret to sync wave task #611
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to be able to use a
preSynchook to run some database migrations. This has been working fine, until such a time as updating the container secrets which are using the External Secret Operator and CRD to create a k8s secret which the job created by thepreSynchook creates mounts.As per this Github issue #9891, the recommended approach is to use Argo sync waves. However
ExternalSecretis not included in one of the predefinedkindsand therefore cannot be part of a different "wave" meaning that any secrets defined byExternalSecretscannot be synced before thepreSynchook as part of the pre Sync wave.This would allow the
ExternalSecretto have an annotation such as the followingAnd a
preSynchook to have a greater weighted sync wave such asAnd all other resources which are part of the deployment would default to weight of
0without the need for an annotation