fix timestamp not right type

argoproj · Sep 28, 2023 · 15aa525 · 15aa525
1 parent 91ef26c
commit 15aa525
Showing 1 changed file with 13 additions and 5 deletions.
diff --git a/pkg/services/github.go b/pkg/services/github.go
@@ -48,7 +48,7 @@ type GitHubStatus struct {
 	TargetURL string `json:"targetURL,omitempty"`
 }
 
-//copy of github:UpdateCheckRunOptions + id
+//copy of github:UpdateCheckRunOptions + id + timestamp as string
 type GitHubCheckRun struct {
 	Id          string            `json:"id"`                     // check_id, actually an int64, but string since we want it to be template'able. (Optional - create new check-run for revision if missing.)
 	Name        string            `json:"name"`                   // The name of the check (e.g., "code-coverage"). (Required.)
@@ -370,27 +370,35 @@ func (g gitHubService) Send(notification Notification, _ Destination) error {
 				u[0],
 				u[1],
 				&github.CreateCheckRunOptions{
-					HeadSHA: &notification.GitHub.revision,
-					Name:    &notification.GitHub.Deployment.Environment,
+					Name:    notification.GitHub.CheckRun.Name,
+					HeadSHA: notification.GitHub.revision,
 				},
 			)
 			if err != nil {
 				return err
 			}
 			id := checkrun.ID
 		}
+		var timestamp *github.Timestamp
+		if notifications.GitHub.CheckRun.CompletedAt != nil {
+			parsedTime, err = time.Parse("2006-01-02T15:04:05Z07:00", notifications.GitHub.CheckRun.CompletedAt)
+			if err != nil {
+				return err
+			}
+			timestamp = &Timestamp{parsedTime}
+		}
 		_, _, err = g.client.Checks.UpdateCheckRun(
 			context.Background(),
 			u[0],
 			u[1],
 			id,
 			&github.UpdateCheckRunOptions{
-				Name       : &notifications.GitHub.CheckRun.Name,       
+				Name       : notifications.GitHub.CheckRun.Name,       
 				DetailsURL : &notifications.GitHub.CheckRun.DetailsURL, 
 				ExternalID : &notifications.GitHub.CheckRun.ExternalID, 
 				Status     : &notifications.GitHub.CheckRun.Status,     
 				Conclusion : &notifications.GitHub.CheckRun.Conclusion, 
-				CompletedAt: &notifications.GitHub.CheckRun.CompletedAt,
+				CompletedAt: timestamp,
 				Output     : &notifications.GitHub.CheckRun.Output,     
 				Actions    : &notifications.GitHub.CheckRun.Actions,    
 			},