Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding AWS SQS Service #144

Merged
merged 3 commits into from
Aug 9, 2023
Merged

Conversation

Rakhmanov
Copy link
Contributor

Resolves: #107

Supports standard Queue types, no FIFO support.

@codecov
Copy link

codecov bot commented Jan 8, 2023

Codecov Report

Patch coverage: 75.70% and project coverage change: +0.58% 🎉

Comparison is base (ba73131) 53.57% compared to head (e45d39b) 54.15%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #144      +/-   ##
==========================================
+ Coverage   53.57%   54.15%   +0.58%     
==========================================
  Files          34       35       +1     
  Lines        3091     3198     +107     
==========================================
+ Hits         1656     1732      +76     
- Misses       1188     1213      +25     
- Partials      247      253       +6     
Files Changed Coverage Δ
pkg/services/services.go 27.57% <33.33%> (+0.25%) ⬆️
pkg/services/awssqs.go 79.59% <79.59%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Rakhmanov
Copy link
Contributor Author

Ready for review @pasha-codefresh @zachaller @alexmt

Copy link

@ju187 ju187 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, just a nit

docs/services/awssqs.md Outdated Show resolved Hide resolved
@Rakhmanov Rakhmanov changed the title Adding AWS SQS Service feat: Adding AWS SQS Service Feb 17, 2023
@pasha-codefresh pasha-codefresh self-requested a review June 20, 2023 11:21
@pasha-codefresh
Copy link
Member

@Rakhmanov LGTM, could you please merge conflicts?

Signed-off-by: Denis Shatilov <[email protected]>
@Rakhmanov
Copy link
Contributor Author

@Rakhmanov LGTM, could you please merge conflicts?

@pasha-codefresh Good to go now.

@pasha-codefresh pasha-codefresh merged commit 8570c23 into argoproj:master Aug 9, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support to AWS SQS (Enhancement)
3 participants