Update documentation for Slack options #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is the example for |
blakepettersson
approved these changes
Sep 27, 2023
Signed-off-by: Andreas Lindhé <[email protected]>
Signed-off-by: Andreas Lindhé <[email protected]>
Signed-off-by: Andreas Lindhé <[email protected]>
Signed-off-by: Andreas Lindhé <[email protected]>
Signed-off-by: Andreas Lindhé <[email protected]>
Signed-off-by: Andreas Lindhé <[email protected]>
Signed-off-by: Andreas Lindhé <[email protected]>
Co-authored-by: Blake Pettersson <[email protected]> Signed-off-by: Andreas Lindhé <[email protected]>
lindhe
force-pushed
the
lindhe/update-options-docs
branch
from
cf1308a
to
9011ca2
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #209 +/- ##
==========================================
+ Coverage 53.79% 53.93% +0.13%
==========================================
Files 35 35
Lines 3305 3278 -27
==========================================
- Hits 1778 1768 -10
+ Misses 1263 1250 -13
+ Partials 264 260 -4 ☔ View full report in Codecov by Sentry. |
|
@blakepettersson I rebased and added the sign-off, so you need to approve again. |
|
@lindhe just one minor issue, also someone with write access to this repo needs to approve (that someone not being me). @zachaller perhaps? |
lindhe
force-pushed
the
lindhe/update-options-docs
branch
from
f5bea9a
to
a7341f5
Compare
pasha-codefresh
approved these changes
Oct 18, 2023
|
Thanks @blakepettersson for review and @lindhe for contribution |
lol3909
pushed a commit
to lol3909/notifications-engine
that referenced
this pull request
Oct 19, 2023
* Clarify option types Signed-off-by: Andreas Lindhé <[email protected]> * Sort alphabetically Signed-off-by: Andreas Lindhé <[email protected]> * Add missing `channels` and `sigingSecret` options Signed-off-by: Andreas Lindhé <[email protected]> * Convert list to Markdown table Signed-off-by: Andreas Lindhé <[email protected]> * Clarify `token` description Signed-off-by: Andreas Lindhé <[email protected]> * Add example column Signed-off-by: Andreas Lindhé <[email protected]> * Populate rest of example fields Signed-off-by: Andreas Lindhé <[email protected]> * Fix typo Co-authored-by: Blake Pettersson <[email protected]> Signed-off-by: Andreas Lindhé <[email protected]> --------- Signed-off-by: Andreas Lindhé <[email protected]> Co-authored-by: Blake Pettersson <[email protected]> Co-authored-by: pasha-codefresh <[email protected]> Signed-off-by: Anthony Mikhail <[email protected]>
pasha-codefresh
added a commit
that referenced
this pull request
Oct 19, 2023
… (#208) * fix: oncePer condition only checked when ` when` condition is true Signed-off-by: Anthony Mikhail <[email protected]> * wip Signed-off-by: Anthony Mikhail <[email protected]> * wip Signed-off-by: Anthony Mikhail <[email protected]> * wip Signed-off-by: Anthony Mikhail <[email protected]> * add debuging Signed-off-by: Anthony Mikhail <[email protected]> * wip Signed-off-by: Anthony Mikhail <[email protected]> * Revert "wip" This reverts commit 6313312. Signed-off-by: Anthony Mikhail <[email protected]> * wip Signed-off-by: Anthony Mikhail <[email protected]> * chore(deps): bump github.com/gregdel/pushover from 1.1.0 to 1.2.1 (#210) Bumps [github.com/gregdel/pushover](https://github.com/gregdel/pushover) from 1.1.0 to 1.2.1. - [Commits](gregdel/pushover@v1.1.0...v1.2.1) --- updated-dependencies: - dependency-name: github.com/gregdel/pushover dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Anthony Mikhail <[email protected]> * GitHub Deployment - Allow Automerge configuration (#193) * Allow AutoMerge configuration Signed-off-by: Mike Splain <[email protected]> * Add docs and test Signed-off-by: Mike Splain <[email protected]> * Fix default and docs Signed-off-by: Mike Splain <[email protected]> --------- Signed-off-by: Mike Splain <[email protected]> Co-authored-by: pasha-codefresh <[email protected]> Signed-off-by: Anthony Mikhail <[email protected]> * Add GitHub Pull Request comments integration (#211) * Add pull request comment to github service Signed-off-by: bennesp <[email protected]> * Add github pull request comment templater test Signed-off-by: bennesp <[email protected]> * Add github pull request comment docs Signed-off-by: bennesp <[email protected]> --------- Signed-off-by: bennesp <[email protected]> Signed-off-by: Anthony Mikhail <[email protected]> * chore(deps): bump codecov/codecov-action from 3 to 4 (#216) Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 3 to 4. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v3...v4) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Anthony Mikhail <[email protected]> * revert to v3 (#218) Signed-off-by: Anthony Mikhail <[email protected]> * Add CardsV2 Support to Google Chat (#201) Signed-off-by: Tom Paulus <[email protected]> Signed-off-by: Anthony Mikhail <[email protected]> * chore(deps): bump expr version and golang as required by expr 1.15 (#221) * bump expr version Signed-off-by: zachaller <[email protected]> * upgrade go expr uses any Signed-off-by: zachaller <[email protected]> * use root go version Signed-off-by: zachaller <[email protected]> * add sum Signed-off-by: zachaller <[email protected]> * change for golang upgrade Signed-off-by: zachaller <[email protected]> --------- Signed-off-by: zachaller <[email protected]> Signed-off-by: Anthony Mikhail <[email protected]> * wip Signed-off-by: Anthony Mikhail <[email protected]> Signed-off-by: Anthony Mikhail <[email protected]> * fix duplicate when using self-service (#227) * fix duplicate when using self-service Signed-off-by: May Zhang <[email protected]> * fix duplicate when using self-service Signed-off-by: May Zhang <[email protected]> * fix tests Signed-off-by: May Zhang <[email protected]> * -s Signed-off-by: May Zhang <[email protected]> * add test cases Signed-off-by: May Zhang <[email protected]> * remove not used method Signed-off-by: May Zhang <[email protected]> --------- Signed-off-by: May Zhang <[email protected]> Signed-off-by: Anthony Mikhail <[email protected]> * Spelling (#220) * spelling: available Signed-off-by: Josh Soref <[email protected]> * spelling: configuration Signed-off-by: Josh Soref <[email protected]> * spelling: emoji Signed-off-by: Josh Soref <[email protected]> * spelling: environment Signed-off-by: Josh Soref <[email protected]> * spelling: github Signed-off-by: Josh Soref <[email protected]> * spelling: notification Signed-off-by: Josh Soref <[email protected]> * spelling: overridden Signed-off-by: Josh Soref <[email protected]> * spelling: successfully Signed-off-by: Josh Soref <[email protected]> * spelling: unmarshal Signed-off-by: Josh Soref <[email protected]> * spelling: variable or Signed-off-by: Josh Soref <[email protected]> * spelling: variables are Signed-off-by: Josh Soref <[email protected]> * spelling: webhook Signed-off-by: Josh Soref <[email protected]> --------- Signed-off-by: Josh Soref <[email protected]> Co-authored-by: pasha-codefresh <[email protected]> Signed-off-by: Anthony Mikhail <[email protected]> * Update documentation for Slack options (#209) * Clarify option types Signed-off-by: Andreas Lindhé <[email protected]> * Sort alphabetically Signed-off-by: Andreas Lindhé <[email protected]> * Add missing `channels` and `sigingSecret` options Signed-off-by: Andreas Lindhé <[email protected]> * Convert list to Markdown table Signed-off-by: Andreas Lindhé <[email protected]> * Clarify `token` description Signed-off-by: Andreas Lindhé <[email protected]> * Add example column Signed-off-by: Andreas Lindhé <[email protected]> * Populate rest of example fields Signed-off-by: Andreas Lindhé <[email protected]> * Fix typo Co-authored-by: Blake Pettersson <[email protected]> Signed-off-by: Andreas Lindhé <[email protected]> --------- Signed-off-by: Andreas Lindhé <[email protected]> Co-authored-by: Blake Pettersson <[email protected]> Co-authored-by: pasha-codefresh <[email protected]> Signed-off-by: Anthony Mikhail <[email protected]> * fix: avoid crashing in gitHubService.Send when repoURL has no / (#219) Signed-off-by: Josh Soref <[email protected]> Co-authored-by: pasha-codefresh <[email protected]> Signed-off-by: Anthony Mikhail <[email protected]> --------- Signed-off-by: Anthony Mikhail <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Mike Splain <[email protected]> Signed-off-by: bennesp <[email protected]> Signed-off-by: Tom Paulus <[email protected]> Signed-off-by: zachaller <[email protected]> Signed-off-by: May Zhang <[email protected]> Signed-off-by: Josh Soref <[email protected]> Signed-off-by: Andreas Lindhé <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Mike Splain <[email protected]> Co-authored-by: pasha-codefresh <[email protected]> Co-authored-by: Benedetto Nespoli <[email protected]> Co-authored-by: Tom Paulus <[email protected]> Co-authored-by: Zach Aller <[email protected]> Co-authored-by: May Zhang <[email protected]> Co-authored-by: Josh Soref <[email protected]> Co-authored-by: Andreas Lindhé <[email protected]> Co-authored-by: Blake Pettersson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My first attempt of using the Slack service failed with
invalid_auth, so I thought that this documentation would need to be updated so not everyone need to play the guessing game.