-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(github) add support for GitHub deployment reference #225
feat(github) add support for GitHub deployment reference #225
Conversation
c300de1
to
8f45b63
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #225 +/- ##
==========================================
- Coverage 55.47% 55.35% -0.13%
==========================================
Files 35 35
Lines 3425 3438 +13
==========================================
+ Hits 1900 1903 +3
- Misses 1248 1256 +8
- Partials 277 279 +2 ☔ View full report in Codecov by Sentry. |
Thank you, could you please update documentation about this option? Also could you please add test for this parameter ? |
f008609
to
05bd3ad
Compare
Hi @pasha-codefresh . I have updated the documentation about this option. Regarding the test for this parameter, I have included in the To actually test the send message, it requires some mock setup that is currently not defined yet and Im afraid Im not enough go test knowledge to implement the skeleton. |
@pasha-codefresh any news on this please? |
Sorry @carloscastrojumo , could you please fix conflicts and i will merge it |
Signed-off-by: Carlos Castro <[email protected]>
05bd3ad
to
69e2e96
Compare
Done @pasha-codefresh :) |
Thank you! |
As it is, the
revision
that triggered the deployment is used as theref
, however it is useful to override so we can pass a tag, a branch or a different SHA.Example: