Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(github) add support for GitHub deployment reference #225

Merged
merged 1 commit into from
Mar 2, 2024

Conversation

carloscastrojumo
Copy link
Contributor

As it is, the revision that triggered the deployment is used as the ref, however it is useful to override so we can pass a tag, a branch or a different SHA.

Example:

Screenshot 2023-10-02 at 20 32 00

@carloscastrojumo carloscastrojumo changed the title Add support for GitHub deployment reference feat(github) add support for GitHub deployment reference Oct 2, 2023
@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Attention: Patch coverage is 26.66667% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 55.35%. Comparing base (ec7fcb4) to head (69e2e96).

Files Patch % Lines
pkg/services/github.go 26.66% 9 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #225      +/-   ##
==========================================
- Coverage   55.47%   55.35%   -0.13%     
==========================================
  Files          35       35              
  Lines        3425     3438      +13     
==========================================
+ Hits         1900     1903       +3     
- Misses       1248     1256       +8     
- Partials      277      279       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pasha-codefresh
Copy link
Member

Thank you, could you please update documentation about this option? Also could you please add test for this parameter ?

@carloscastrojumo

@carloscastrojumo carloscastrojumo force-pushed the github-reference branch 2 times, most recently from f008609 to 05bd3ad Compare November 2, 2023 23:29
@carloscastrojumo
Copy link
Contributor Author

Hi @pasha-codefresh . I have updated the documentation about this option. Regarding the test for this parameter, I have included in the TestGetTemplater_GitHub_Deployment test.

To actually test the send message, it requires some mock setup that is currently not defined yet and Im afraid Im not enough go test knowledge to implement the skeleton.

@carloscastrojumo
Copy link
Contributor Author

@pasha-codefresh any news on this please?

@pasha-codefresh
Copy link
Member

Sorry @carloscastrojumo , could you please fix conflicts and i will merge it

@carloscastrojumo
Copy link
Contributor Author

Done @pasha-codefresh :)

@pasha-codefresh
Copy link
Member

Thank you!

@pasha-codefresh pasha-codefresh merged commit d4eaae8 into argoproj:master Mar 2, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants