Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(opsgenie): Add support for setting alias in Opsgenie notification #268

Merged

Conversation

gazidizdaroglu
Copy link
Contributor

@gazidizdaroglu gazidizdaroglu commented Feb 9, 2024

This PR adds support for setting the alias field in the Opsgenie notifications.

Copy link

codecov bot commented Feb 9, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (4222fe0) 54.99% compared to head (0803b19) 55.14%.

Files Patch % Lines
pkg/services/opsgenie.go 42.85% 7 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #268      +/-   ##
==========================================
+ Coverage   54.99%   55.14%   +0.15%     
==========================================
  Files          35       35              
  Lines        3386     3400      +14     
==========================================
+ Hits         1862     1875      +13     
  Misses       1251     1251              
- Partials      273      274       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pasha-codefresh
Copy link
Member

@gazidizdaroglu Great job, could you please add this parameter description to documentation ?

@gazidizdaroglu
Copy link
Contributor Author

@pasha-codefresh sure, let me update the documentation

Signed-off-by: Gazi Dizdaroğlu <[email protected]>
@gazidizdaroglu
Copy link
Contributor Author

@pasha-codefresh I've updated the doc

@pasha-codefresh
Copy link
Member

Wow, amazing work, thank you

@pasha-codefresh pasha-codefresh merged commit ace379e into argoproj:master Feb 12, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants