Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Github integration instructions #306

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update Github integration instructions #306

wants to merge 2 commits into from

Conversation

Amphaal
Copy link

@Amphaal Amphaal commented Jun 17, 2024

following up argoproj/argo-cd#18546 (comment) instructions

@pasha-codefresh
Copy link
Member

@Amphaal please fix DCO check

@pasha-codefresh
Copy link
Member

@CodiumAI-Agent /review

@CodiumAI-Agent
Copy link

PR Reviewer Guide 🔍

⏱️ Estimated effort to review [1-5] 3
🏅 Score 85
🧪 Relevant tests No
🔒 Security concerns No
⚡ Key issues to review Possible Bug:
Ensure that the placeholders like , , and are meant to be replaced by the user or should be dynamically populated. If not handled properly, it could lead to configuration errors.
Consistency Issue:
The use of {{.context.argocdUrl}} in the new templates should be verified to ensure that it is correctly defined and accessible in all contexts where these templates are used.
Documentation:
It would be beneficial to include more detailed comments or documentation within the PR to explain the purpose and usage of the newly added templates, especially for users who might not be familiar with the specific configurations.

pasha-codefresh
pasha-codefresh requested changes Jun 17, 2024
View reviewed changes
docs/services/github.md
template.app-deployed: |
message: |
Application {{.app.metadata.name}} is now running new version of deployments manifests.
github:
repoURLPath: "{{.app.spec.source.repoURL}}"
revisionPath: "{{.app.status.operationState.syncResult.revision}}"
revisionPath: "{{.app.status.operationState.operation.sync.revision}}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why would you take it from operation instead syncResult?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it did not work otherwise with my setup, and I could not tell why ! In my Application manifests, syncResult was missing for some reasons. I double checked this time and I can now find it. What is the difference between both ? Why would this happen ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

syncResult exist when sync already finished. It may not exist if application is just created and sync still didnt happen before

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pasha-codefresh pasha-codefresh pasha-codefresh requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Amphaal @pasha-codefresh @CodiumAI-Agent