Allow GitHub InstallationID override #324
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This likely needs more work, but I wanted some input before digging deeper into it.
Right now, we can use a single GitHub App Installation for these notifications; if you have other GitHub organizations which have a unique installation ID, you cannot use the GitHub service for all of them.
There are a couple of existing solutions here:
I am proposing a reasonably simple change that would allow the Installation ID to be passed into the template to override the default Installation ID. This would require the installation ID to be attached to an ArgoCD application as info metadata or custom templates for each GitHub organization.
This will still use a single GitHub App, but it could be installed in multiple GitHub organizations.
ex: