Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add priority support for opsgenie #329

Closed

Conversation

patrick-tang
Copy link

add priority support for opsgenie
Signed-off-by: Patrick Tang [email protected]

@patrick-tang
Copy link
Author

patrick-tang commented Aug 22, 2024

Hi,
This is the first time I'm making a pull request. Apologize if I'm doing anything wrong and I'll improve it.
Kindly please let me know how I can put a proper description and what else I'm missing in my PR.
We're trying to integrate ArgoCD with OpsGenie, however noticed priority was not able to be picked up by notification to send to OpsGenenie, so would expect the priority support can be added.
Thanks,
Patrick

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 55.45%. Comparing base (f485671) to head (492241c).
Report is 3 commits behind head on master.

Files Patch % Lines
pkg/services/opsgenie.go 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #329      +/-   ##
==========================================
+ Coverage   55.35%   55.45%   +0.10%     
==========================================
  Files          35       35              
  Lines        3438     3446       +8     
==========================================
+ Hits         1903     1911       +8     
  Misses       1256     1256              
  Partials      279      279              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pasha-codefresh
Copy link
Member

Hey @patrick-tang , thank you for your contribution. Your change also covered in this PR https://github.com/argoproj/notifications-engine/pull/339/files . I think it will be better just merge last one because it covers all fields. For sure PR that you did is amazing and i am sorry that i didnt review it earlier, i just didnt notice it.

@pasha-codefresh
Copy link
Member

Closing it, but again, thank you for your contribution @patrick-tang . Next time just assign review to me, so i can see it in notifications

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants