Fix: Update Installation guides to install community.general collection #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgodaA
reviewed
Jun 23, 2022
| @@ -79,6 +79,7 @@ $ make install | |||
| # Manual installation | |||
| $ ansible-galaxy collection install arista.avd:==2.0.0 | |||
| $ ansible-galaxy collection install arista.cvp:==2.1.2 | |||
| $ ansible-galaxy collection install community.general | |||
There was a problem hiding this comment.
Do we need this collection? Any reason?
There was a problem hiding this comment.
In this repo it is needed for the callback defined in the playbook.
There was a problem hiding this comment.
We can simply remove the stdout yaml from the ansible.cfg, instead of adding it here to install. Let me know if this collection is adding any value? (Because I don't see any difference with out yaml output)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
arista.avdis no longer requiring this collection, so it will not be installed automatically.Since this demo use callbacks contained in the
community.generalcollection, it should be installed.