Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Layers #1826

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Layers #1826

wants to merge 10 commits into from

Conversation

vniacob
Copy link
Contributor

@vniacob vniacob commented May 16, 2022

  • Three working layers implementation with different color on preview panel.
  • Three different loop Count for every layer
  • Fast enabling layer control
  • Fast queue and reopen of the last file through buttons
    LaserGRBL_yIlLCB0opJ

@vniacob
- Three working layers implementation with different color on preview…
f60c061 
… panel.

- Three different loop Count for every layer
- Fast enabling layer control
- Fast reopen of the last file
@arkypita
Copy link
Owner

looks fine! leave me a few days to review and test (I'm away for job)

@vniacob
Copy link
Contributor Author

vniacob commented May 17, 2022 •
edited
Loading

there might be a problem in GbrlFile "list" concurrent modification, sometimes it throws exceptions, but my C# knowledge does not let me fix it...

@vniacob
Copy link
Contributor Author

vniacob commented May 18, 2022 •
edited
Loading

The point is in line 1304 of GbrlFile, maybe should I use a clone of list[i] before get the enumerator?

@arkypita
Copy link
Owner

Hi, I am currently busy on business.
I'll look at this later.

@arkypita
Copy link
Owner

arkypita commented Jun 4, 2022

I tried the code, without having time to go and look under the hood. It seems like a good solution but I could not verify that the system is consistent with the rest of the project.

What I mean:

  • export the GCODE ("file - quick save" and "file - save advanced")
  • save as project (feature not developed by me)
  • ability of LaserGRBL to recover from a job hang, starting from the last command sent
  • execution time preview and real-time execution time projection (this already did not work if you do multiple passes because it works on the time of a single pass)

I've seen happening that probable multithreading problem you were talking about, but I don't have time to look at it right now. Unfortunately I can only dedicate half a day every 2/3 weeks!

vniacob added 3 commits June 4, 2022 15:37
@vniacob
Revision on gcode export, deletion of useless code
216002b
@vniacob
Fixes after verifications for:
d74a97e 
- Saving as GCODE (fast e not)
- Now estimated time update correctly on loop and abilitation modification
@vniacob
switch back to .net 4.0
7de741d
@vniacob
Copy link
Contributor Author

vniacob commented Jun 4, 2022 •
edited
Loading

Ok, checks carried out:

  • GCODE export verified, loops considered are the main form ones, Ok fast and normal save.
  • project saving works as before, that is only raster conversion is stored.
  • due to the GrblFile management of loops (commands generation and analyze), job recover from specific line works perfectly
  • Now estimated time update correctly on loop and abilitation modification

@vniacob
Copy link
Contributor Author

vniacob commented Jul 25, 2022

Any news for this request?

@vniacob
Copy link
Contributor Author

vniacob commented Sep 15, 2022 •
edited
Loading

I found a bug... :(
Note: It is only a graphical issue, laser work works properly

LaserGRBL_BKIoQnv856.mp4

@FHEMUser
Copy link

Can i add this to LaserGRBL by myself ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vniacob @arkypita @FHEMUser