Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to hyper1 and associated deps #660

Open
wants to merge 2 commits into
base: next
Choose a base branch
from
Open

Bump to hyper1 and associated deps #660

wants to merge 2 commits into from

Conversation

mzeitlin11
Copy link
Collaborator

Bumped to use hyper1 and associated deps. Thought about feature-gating to support both hyper1 and hyper0 simultaneously, but kept simple for now since that adds some annoying complexity and just supporting hyper1 makes things easier as we (hopefully have more time soon!) continue to figure out the best ergonomics for client options in the next branch.

@mzeitlin11 mzeitlin11 mentioned this pull request Feb 9, 2025
2 tasks
Comment on lines +107 to +111
let body = match body {
None => Full::new(Bytes::new()),
Some(bytes) => Full::new(bytes),
};
let req = req_builder.body(body)?;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
let body = match body {
None => Full::new(Bytes::new()),
Some(bytes) => Full::new(bytes),
};
let req = req_builder.body(body)?;
let req = req_builder.body(Full::new(body.unwrap_or_default()))?;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants