Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump upload-artifact to v4 #672

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

augustoccesar
Copy link
Contributor

Summary

actions/upload-artifact v3 has been deprecated on November 30, 2024 and is causing generate-public-api to break.

Breaking Changes

  1. On self hosted runners, additional firewall rules may be required.

  2. Uploading to the same named Artifact multiple times.

  3. Due to how Artifacts are created in this new version, it is no longer possible to upload to the same named Artifact multiple times. You must either split the uploads into multiple Artifacts with different names, or only upload once. Otherwise you will encounter an error.

  4. Limit of Artifacts for an individual job. Each job in a workflow run now has a limit of 500 artifacts.

  5. With v4.4 and later, hidden files are excluded by default.

Checklist

@augustoccesar augustoccesar force-pushed the augustoccesar/bump-upload-artifact branch from a060c6c to eeb11a0 Compare February 20, 2025 09:02
[actions/upload-artifact](https://github.com/actions/upload-artifact) v3 has been deprecated on November 30, 2024. This bumps to v4.

> Breaking Changes
>
>    On self hosted runners, additional firewall rules may be required.
>
>    Uploading to the same named Artifact multiple times.
>
>    Due to how Artifacts are created in this new version, it is no longer possible to upload to the same named Artifact multiple times. You must either split the uploads into multiple Artifacts with different names, or only upload once. Otherwise you will encounter an error.
>
>    Limit of Artifacts for an individual job. Each job in a workflow run now has a limit of 500 artifacts.
>
>    With v4.4 and later, hidden files are excluded by default.
@augustoccesar augustoccesar force-pushed the augustoccesar/bump-upload-artifact branch from eeb11a0 to 57d2dbf Compare February 20, 2025 09:06
@augustoccesar
Copy link
Contributor Author

augustoccesar commented Feb 20, 2025

native-tls got a new release yesterday which bumped their MSRV from 1.53.0 to 1.80.0, but not quite sure why is it trying to use the 0.2.14. Locally it is using 0.2.12 🤔 Guess might be cache hit...

sfackler/rust-native-tls@v0.2.13...v0.2.14

@augustoccesar
Copy link
Contributor Author

Disabling the cache did not solve. Also noticed that tokio-native-tls had dependency to native-tls = "0.2", which might be the cause. Will take a look.

@augustoccesar augustoccesar force-pushed the augustoccesar/bump-upload-artifact branch from b6ad93b to 57d2dbf Compare February 20, 2025 09:25
@augustoccesar
Copy link
Contributor Author

tests fails here, but should be fixed by #673

@augustoccesar
Copy link
Contributor Author

@arlyon let me know if you prefer both this (#672) and #673 to be a single PR that makes the pipeline green.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant