Skip to content

Conversation

@d80tb7
Copy link
Collaborator

@d80tb7 d80tb7 commented Oct 12, 2024

The scheduling key check used to be in theQueuedGangIterator. I've moved it to to the QueuedJobsIterator because:

  • It simplifies QueuedGangIterator
  • It means we exit asap if we know a job is unscheduable.
  • The QueuedJobsIterator is only used for Queued (i.e. not evicted) jobs. This means we don't have to mess around with invalidating and skipping scheduling keys.

@d80tb7 d80tb7 changed the title Move Scheduling Key Check into Move scheduling key check into the QueuedJobsIterator Oct 12, 2024
Signed-off-by: Chris Martin <[email protected]>
Signed-off-by: Chris Martin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants