Skip to content

Fix potential row resource leak #4362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Fix potential row resource leak #4362

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7a6ccbc
Fix row resource leak
jparraga-stackav May 29, 2025
ed0aba3
Merge branch 'master' into fix-leak
d80tb7 Jun 30, 2025
d99e3c2
Merge branch 'master' into fix-leak
d80tb7 Jul 8, 2025
935d879
Merge branch 'master' into fix-leak
d80tb7 Jul 9, 2025
6885989
Merge branch 'master' into fix-leak
d80tb7 Jul 9, 2025
1c9c370
Merge branch 'master' into fix-leak
dejanzele Jul 14, 2025
cdd29c7
Merge branch 'master' into fix-leak
dejanzele Jul 17, 2025
1b2aabd
Merge branch 'master' into fix-leak
dejanzele Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions internal/scheduler/database/job_repository.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,15 @@
AccessMode: pgx.ReadWrite,
DeferrableMode: pgx.Deferrable,
}, func(tx pgx.Tx) error {

Check failure on line 195 in internal/scheduler/database/job_repository.go

View workflow job for this annotation

GitHub Actions / lint / Lint Go 

File is not properly formatted (gofumpt)
var rows pgx.Rows
var queryErr error
defer func() {
if rows != nil {
rows.Close()
}
}()

for _, chunk := range chunks {
tmpTable, err := insertRunIdsToTmpTable(ctx, tx, chunk)
if err != nil {
Expand All @@ -203,11 +212,10 @@
FROM %s as tmp
JOIN job_run_errors ON job_run_errors.run_id = tmp.run_id`

rows, err := tx.Query(ctx, fmt.Sprintf(query, tmpTable))
if err != nil {
return err
rows, queryErr = tx.Query(ctx, fmt.Sprintf(query, tmpTable))
if queryErr != nil {
return queryErr
}
defer rows.Close()
for rows.Next() {
var runId string
var errorBytes []byte
Expand All @@ -221,6 +229,8 @@
}
errorsByRunId[runId] = jobError
}

rows.Close()
}
return nil
})
Expand Down
Loading