feat: add support for disabling ingresses in all armada helm charts (global ingress.enabled setting) #4472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ingress.enabled setting) Signed-off-by: Dejan Zele Pejchev <[email protected]>
dejanzele
force-pushed
the
feat/toggleable-ingresses
branch
from
842309b to
4aac4a8
Compare
dejanzele
requested review from
JamesMurkin,
eleanorpratt and
robertdavidsmith
and removed request for
robertdavidsmith
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature PR which adds support for toggleable ingresses.
What this PR does / why we need it:
Some armada component ingresses can be disabled (i.e. server) and some cannot (i.e. scheduler).
This creates an issue if you want to deploy armada without ingress as you also need to provide a cluster issuer.