feat: do not create standalone services for native sidecars if ingress ports match #4500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Enhancement
What this PR does / why we need it:
Fixes service creation logic to enable service reuse when ServiceConfig and IngressConfig have overlapping ports, preventing duplicate service creation in Armada job submissions.
Problem: Previously, when a job specified both ServiceConfig and IngressConfig with overlapping ports (e.g., ServiceConfig with ports [7078, 4040, 4180] and IngressConfig with port [4180]), Armada would create separate services instead of reusing the existing service.