Remove outdated gang eviction assertions #4506
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This used to reconcile the scheduling context with an intermediate state, however that intermediate state has since been removed It is no longer obvious what this should reconcile as really the only way to work out what should have been evicted would be to work something that does the same logic as the original code its validating We could update this code to do some new form of reconciliation but I think instead we should remove it as: - We now have better test coverage of this and test coverage makes more sense than assertions - The assertions code typically rots and generally is something we're deprecating Signed-off-by: JamesMurkin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This used to reconcile the scheduling context with an intermediate state, however that intermediate state has since been removed
It is no longer obvious what this should reconcile as really the only way to work out what should have been evicted would be to work something that does the same logic as the original code its validating
We could update this code to do some new form of reconciliation but I think instead we should remove it as: