aml-s9xx-box: bsp-cli hashing fixes #6839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size/medium
rpardini
requested review from
SteeManMI,
a team and
igorpecovnik
as code owners
rpardini
force-pushed
the
pr/aml-s9xx-box-bsp-cli-hashing-fixes
branch
3 times, most recently
from
36e0433
to
8655b83
Compare
… with the hook; half fixes armbian#6817 - this is technically cheating, but works - add TODO's ref the manual include'ing of files that are not hashed in the bsp-cli
…9xx-box` to `config/optional/boards/aml-s9xx-box/_packages/bsp-cli`; fixes armbian#6817 - with this: - those files are automatically hashed by the bsp-cli hashing mechanism - no need to copy them manually any more
rpardini
force-pushed
the
pr/aml-s9xx-box-bsp-cli-hashing-fixes
branch
from
8655b83
to
769ab72
Compare
SteeManMI
approved these changes
Jun 30, 2024
There was a problem hiding this comment.
@rpardini Thank you very much. You didn't need to do this, this is really going above and beyond. I would have been happy with a couple of.pointers.on what needed to be done and left to do the legwork myself. Again, thank you.
igorpecovnik
added
Ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aml-s9xx-box: bsp-cli hashing fixes
packages/bsp/aml-s9xx-boxtoconfig/optional/boards/aml-s9xx-box/_packages/bsp-cli; fixes [Bug]: bsp-cli package isn't being rebuilt #6817