Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helios64: fix helios64-heartbeat-led.service #7765

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

prahal
Copy link
Collaborator

@prahal prahal commented Jan 31, 2025

While syncing with upstream Linux helios64 dts for 6.9 I missed the diff for the helios64 status led label (upstream was helios64:green:status instead of Armbian helios64::status) and thus broke armbian helios64-heartbeat-led.service.

This commit restores the Armbian label helios64::status to let helios64-heartbeat-led.service starts.

Fixes: cbaf67f ("Sync helios64 to its updated 6.9 dts")

Description

I revert to helios64::status label for the Helios64 status led. The change to upstream label helios64:green:status breaks helios64-heartbeat-led.service (either way the LED is not green but blue). Keep old Armbian label helios64::status for now.

Issue reported by BipBI1981 on 6.12.

 root@helios64:~# systemctl status helios64-heartbeat-led.service
× helios64-heartbeat-led.service - Enable heartbeat & network activity led on Helios64
     Loaded: loaded (/etc/systemd/system/helios64-heartbeat-led.service; enabled; preset: enabled)
     Active: failed (Result: exit-code) since Thu 2025-01-16 20:26:24 CET; 34min ago
    Process: 2899 ExecStart=bash -c echo heartbeat | tee /sys/class/leds/helios64\:\:status/trigger (code=exited, status=1/FAILURE)
   Main PID: 2899 (code=exited, status=1/FAILURE)
        CPU: 20ms

Jan 16 20:26:24 helios64 systemd[1]: Starting helios64-heartbeat-led.service - Enable heartbeat & network activity led on Helios64...
Jan 16 20:26:24 helios64 bash[2906]: tee: '/sys/class/leds/helios64::status/trigger': No such file or directory
Jan 16 20:26:24 helios64 bash[2906]: heartbeat
Jan 16 20:26:24 helios64 systemd[1]: helios64-heartbeat-led.service: Main process exited, code=exited, status=1/FAILURE
Jan 16 20:26:24 helios64 systemd[1]: helios64-heartbeat-led.service: Failed with result 'exit-code'.
Jan 16 20:26:24 helios64 systemd[1]: Failed to start helios64-heartbeat-led.service - Enable heartbeat & network activity led on Helios64. 

How Has This Been Tested?

  • Boot on 6.12 current. Verified led sysfs file is now /sys/class/leds/helios64::status and that helios64-heartbeat-led.service starts successfully.
  • Boot on 6.13 edge. Verified led sysfs file is now /sys/class/leds/helios64::status and that helios64-heartbeat-led.service starts successfully.
  • Boot on 6.9 build. Verified led sysfs file is now /sys/class/leds/helios64::status and that helios64-heartbeat-led.service starts successfully.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings

While syncing with upstream Linux helios64 dts for 6.9 I missed
the diff for the helios64 status led label (upstream was
helios64:green:status instead of Armbian helios64::status) and
thus broke armbian helios64-heartbeat-led.service.

This commit restores the Armbian label helios64::status to let
helios64-heartbeat-led.service starts.

Fixes: cbaf67f ("Sync helios64 to its updated 6.9 dts")
Signed-off-by: Alban Browaeys <[email protected]>
@prahal prahal requested a review from igorpecovnik as a code owner January 31, 2025 05:08
@github-actions github-actions bot added size/small PR with less then 50 lines Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... labels Jan 31, 2025
@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge 02 Milestone: First quarter release and removed Needs review Seeking for review labels Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
02 Milestone: First quarter release Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines
Development

Successfully merging this pull request may close these issues.

2 participants