Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore mkspi cli only images #7809

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Chore mkspi cli only images #7809

merged 1 commit into from
Feb 10, 2025

Conversation

redrathnure
Copy link
Contributor

Description

Set HAS_VIDEO_OUTPUT="no" to skip desktop images building.

There is not practival sense in Gnome for this kind of boards. Usually we use KlipperScreen or/and WEB UI.
Desktop images are hardly usable on this small screen.

How Has This Been Tested?

Ubuntu "Noble" Server image

  • Ubuntu Noble Server + MKSPI + TS35 screen + Klipper/KlipperScreen

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@github-actions github-actions bot added size/large PR with 250 lines or more Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... Documentation Documentation changes or additions GitHub GitHub-related changes like labels, templates, ... labels Feb 9, 2025
@redrathnure
mkspi: do not build desktop images
678255e 
There is not practival sense in Gnome for this kind of boards. Usually we use KlipperScreen or/and WEB UI.
@redrathnure redrathnure force-pushed the chore-mkspi-cli-only-images branch from b842eb6 to 678255e Compare February 9, 2025 10:21
@github-actions github-actions bot added size/small PR with less then 50 lines and removed size/large PR with 250 lines or more labels Feb 9, 2025
@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge and removed Needs review Seeking for review labels Feb 9, 2025
@EvilOlaf EvilOlaf mentioned this pull request Feb 9, 2025
Merged
6 tasks
@igorpecovnik igorpecovnik merged commit fe50e4a into armbian:main Feb 10, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorpecovnik igorpecovnik igorpecovnik approved these changes

@rpardini rpardini Awaiting requested review from rpardini

@hzyitc hzyitc Awaiting requested review from hzyitc

@EvilOlaf EvilOlaf Awaiting requested review from EvilOlaf

@littlecxm littlecxm Awaiting requested review from littlecxm

@TRSx80 TRSx80 Awaiting requested review from TRSx80

Assignees
No one assigned
Labels
Documentation Documentation changes or additions GitHub GitHub-related changes like labels, templates, ... Hardware Hardware related like kernel, U-Boot, ... Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@redrathnure @igorpecovnik