Add support for Rock 2A and 2F #7820
Conversation
To avoid unexpected errors caused by ID_NET_SLOT being empty when using lower version udev
github-actions
bot
added
size/small
|
@RadxaStephen @lsj123lsjlsj @RadxaYuntian Please review together |
Co-authored-by: ZHANG Yuntian <[email protected]>
|
Hi @amazingfate , i see arm64: dts: rk3528: use lima driver for gpu was submitted by you, could you please tell me if you tested glmark-es2 under gnome X11? |
| @@ -51,4 +51,12 @@ function post_install_kernel_debs__install_aic8800_dkms_package() { | |||
| declare -ag if_error_find_files_sdcard=("/var/lib/dkms/aic8800*/*/build/*.log") | |||
| use_clean_environment="yes" chroot_sdcard_apt_get_install "/tmp/${aic8800_dkms_file_name} /tmp/aic8800-firmware_${latest_version}_all.deb" | |||
| use_clean_environment="yes" chroot_sdcard "rm -f /tmp/aic8800*.deb" | |||
| use_clean_environment="yes" chroot_sdcard "mkdir -p /usr/lib/systemd/network/" | |||
| use_clean_environment="yes" chroot_sdcard 'cat <<- EOF > /usr/lib/systemd/network/50-radxa-aic8800.link | |||
| [Match] | |||
There was a problem hiding this comment.
Can we add a MAC prefix match as well?
There was a problem hiding this comment.
https://www.freedesktop.org/software/systemd/man/latest/systemd.link.html#MACAddress=
MACAddress cannot use * wildcards
There was a problem hiding this comment.
Can't it be more specific to affect AIC drivers only?
There was a problem hiding this comment.
The driver for the aic8800 is reported as ID_NET_DRIVER=usb, and the other cards are the real driver name, e.g. rtw_8822bu.
There was a problem hiding this comment.
And the aic8800 driver for other interfaces will not be affected by the system's default systemd.link rule, I think the current change is appropriate
There was a problem hiding this comment.
Please also check the driver name for SDIO version.
There was a problem hiding this comment.
armbian currently has no products or configurations that support the sdio aic8800.
There was a problem hiding this comment.
hinlink ht2 is the one with aic8800 sdio, while this board is not mainlined and the driver is inside bsp kernel.
I have tested with hinlink ht2, ubuntu noble gnome x11 session the glmark-es2 score is also 80~90. While glmark2-es2-wayland is better. And score of glmark-es2 under wayland session can reach to 120. |
Thanks for the test, that doesn't look like I did anything wrong or missed any changes. |
Description
How Has This Been Tested?
./compile.sh build BOARD=rock-2a BRANCH=vendor BUILD_DESKTOP=yes BUILD_MINIMAL=no DESKTOP_APPGROUPS_SELECTED= DESKTOP_ENVIRONMENT=gnome DESKTOP_ENVIRONMENT_CONFIG_NAME=config_base KERNEL_CONFIGURE=no RELEASE=noble DOWNLOAD_MIRROR=china./compile.sh build BOARD=rock-2f BRANCH=vendor BUILD_DESKTOP=yes BUILD_MINIMAL=no DESKTOP_APPGROUPS_SELECTED= DESKTOP_ENVIRONMENT=gnome DESKTOP_ENVIRONMENT_CONFIG_NAME=config_base KERNEL_CONFIGURE=no RELEASE=noble DOWNLOAD_MIRROR=chinaChecklist: