This repository was archived by the owner on Dec 2, 2024. It is now read-only.
Gi clipmaps fix latency and crashes#213
Merged
luboslenco merged 6 commits intoarmory3d:mainfrom Aug 8, 2024
Merged
Conversation
luboslenco
reviewed
Aug 3, 2024
luboslenco
reviewed
Aug 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes crashes when allocating mipmaps for 3D images.
I think that the pc runs out of ram because mipmapping for 3d images is, correct my if i'm wrong, 8 times the size of the original image. And anisotropy, precomputed direction, and clipmaps are stored in these images by extending their sizes so we don't use mipmaps.
@luboslenco this is kind of crucial that you merge this one, I'm opening an 'overhaul' pull request for armory but even with the current code the patch is needed.