Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved delete hotkeys #2185

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

manstie
Copy link
Contributor

@manstie manstie commented Nov 26, 2023

I am an avid user of ctrl + backspace to delete whole words when typing, and I noticed there was ctrl + arrows for navigation already implemented, and none for deleting.

I ended up with including deletion functions for the existing keyboard navigation modifiers of alt and ctrl.

The reason for moving removeRow to shift+[Delete] is because this hotkey deletes a whole line in vscode (which seems like similar functionality), and it is close/similar to the removeColumn hotkey.

This seems to maintain expectations for keyboard functionality on Windows and Ubuntu (Australian keyboard), please let me know if this messes with other keyboard layouts / operating systems (I have no idea how you manage to maintain functionality for all of them, kudos to you).

@arnog
Copy link
Owner

arnog commented Nov 28, 2023

All keyboards have a Backspace key, but not all keyboards have a Delete key.

Add:

  • shift+[Delete] for deleteBackward
  • shift+[Backspace] for deleteForward
  • alt+shift+[Backspace] for deleteToGroupStart
  • ctrl+shift+[Backspace] for deleteToGroupEnd
  • shift+alt+[Backspace] for removeRow

I think that would be consistent with existing shortcuts, and should work for all platforms and keyboard layouts.

@manstie
Copy link
Contributor Author

manstie commented Dec 1, 2023

shift+[Backspace] for deleteForward conflicts with the existing removeColumn, and same with adding alt+shift+[Backspace] for deleteToGroupStart and shift+alt+[Backspace] for removeRow, which ends up making neither of the hotkeys work 😭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants