Added unit tests for the pad function and fixed pad function return v… #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roaffix
reviewed
Feb 28, 2024
| @@ -22,4 +22,4 @@ def pad(arr: AFArray, begin_shape: tuple[int, ...], end_shape: tuple[int, ...], | |||
| end_c_shape.c_array, | |||
| border_type.value, | |||
| ) | |||
| return NotImplemented | |||
roaffix
approved these changes
Feb 28, 2024
roaffix
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a suite of unit tests for pad.py located within the create_array directory. The primary function in this file is to add padding to a given array.
No Padding: Ensures that when given 0 padding, the array remains its original shape
Negative Padding: Ensures that when given negative padding, the pad function properly handles this case
Padding Shape: Ensures that when padding is added, the correct padding shape is seen in the padded array
Pad Return Value Fix: Pad originally returned "Not Implemented"