Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use artefactual repositories for packages #19

Merged
merged 1 commit into from
Aug 27, 2020

Conversation

mamedin
Copy link
Contributor

@mamedin mamedin commented Aug 26, 2020

The old repos have not been updated to use acmetool v0.2.1. The v0.2.1 packages
have been created with am-packbuild and published in artefactual package
repositories:

https://packages.archivematica.org/acmetool/ubuntu/
https://packages.archivematica.org/acmetool/centos/

Connects to #17

The old repos have not been updated to use acmetool v0.2.1. The v0.2.1 packages
have been created with am-packbuild and published in artefactual package
repositories.
@mamedin
Copy link
Contributor Author

mamedin commented Aug 26, 2020

NOTE: Ubuntu 20.04 (focal) has included acmetool 0.2.1 in official repositories, so we don't need to add the repo for Ubuntu 20.04:

https://packages.ubuntu.com/focal/acmetool

Copy link

@DavidHume-ArtefactualSystems DavidHume-ArtefactualSystems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mamedin - makes sense to me - I gather you've tried this role with the changes, on one of your test clusters or otherwise?

(Later in day edit: @luisilara and @hakamine have anyway, so there we go!)

@luisilara
Copy link

Tested with RHEL 7.6 without a problem

acmetool --version
go version go1.13.14 linux/amd64 gc cgo=true
acmetool CentOS version 0.2.1

Copy link

@luisilara luisilara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@hakamine hakamine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mamedin. I tested on ubuntu 18.04 for a new deployment, and also for an upgrade (from the old acmetool package), no problems. Also noticed that the new packages install on /bin/acmetool (instead of /usr/bin/acmetool as the old packages did)

@mamedin
Copy link
Contributor Author

mamedin commented Aug 27, 2020

Thank you @mamedin. I tested on ubuntu 18.04 for a new deployment, and also for an upgrade (from the old acmetool package), no problems. Also noticed that the new packages install on /bin/acmetool (instead of /usr/bin/acmetool as the old packages did)

Thanks Hector, that's true. It should be changed here:

https://github.com/artefactual-labs/am-packbuild/blob/qa/1.x/debs/bionic/acmetool/debian/rules#L21-L23
https://github.com/artefactual-labs/am-packbuild/blob/qa/1.x/debs/xenial/acmetool/debian/rules#L21-L23

I'm going to create a new am-packbuild PR and new packages because the 20.04 package uses /usr/bin path.

CentOS is already using /usr/bin path.

@mamedin
Copy link
Contributor Author

mamedin commented Aug 27, 2020

Thank you @mamedin. I tested on ubuntu 18.04 for a new deployment, and also for an upgrade (from the old acmetool package), no problems. Also noticed that the new packages install on /bin/acmetool (instead of /usr/bin/acmetool as the old packages did)

Thanks Hector, that's true. It should be changed here:

https://github.com/artefactual-labs/am-packbuild/blob/qa/1.x/debs/bionic/acmetool/debian/rules#L21-L23
https://github.com/artefactual-labs/am-packbuild/blob/qa/1.x/debs/xenial/acmetool/debian/rules#L21-L23

I'm going to create a new am-packbuild PR and new packages because the 20.04 package uses /usr/bin path.

CentOS is already using /usr/bin path.

New ubuntu packages with fixed path (/usr/bin) have been added to the repo.

@mamedin mamedin merged commit c3c2602 into master Aug 27, 2020
@mamedin mamedin deleted the dev/use-artefactual-repositories branch August 27, 2020 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants