Fix PHP 8.x deprecation warnings (#1960) #1961
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add ReturnTypeWillChange attribute to all offset Get/Set/Unset/Exists methods
anvit
force-pushed
the
dev/issue-1960-deprecation-warnings
branch
from
a9463f5 to
9ddc26e
Compare
Fix deprecation warnings for call_user_func_array calls that use $this in the callable which isn't required and has been deprecated in PHP 8.2
Add missing property to sfEadPlugin.class.php since dynamically creating properties is deprecated in PHP 8.
Fix instances of strlen and strtolower in sfEadPlugin, BaseActor, and BaseProperty that could run with null values and generate deprecation warnings, since PHP 8 expects strlen and strtolower to only accept strings.
anvit
force-pushed
the
dev/issue-1960-deprecation-warnings
branch
from
2fd70fa to
3c10c88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BaseProperty that could run with null values and generate deprecation
warnings, since PHP 8 expects strlen and strtolower to only accept
strings.
properties is deprecated in PHP 8.