Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper redirect for posts hosted by gh-pages #15

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Proper redirect for posts hosted by gh-pages #15

wants to merge 4 commits into from

Conversation

Cheng-Vang
Copy link

Hello Artem,

I am using your Bef template for my Jekyll blog and I ran into this issue where my recent posts where not redirecting properly. Upon inspection I noticed that you are anchoring root_url along with the post.url. Perhaps this works with someone who is using a registered domain name but I utilize gh-pages.

Consequently, the blog crashes everytime any recent post is clicked due to not being redirected properly. The commented out code is my fix for proper recent post redirection for those hosting their site on gh-pages. I believe there should be a note in either your readme or _config.yaml that tells the user that if they plan to host their site on gh-pages then they should either comment or delete the current active anchor and uncomment the fix.

@Cheng-Vang
Copy link
Author

Another issue I found was with the contact me page. It was not functioning at all. As a result, I referred to the Formspree docs while taking a look at your source code.

It appears the form input for an individual's "name" was being sent as an email address. So, I've changed the form input to actually send a name versus an email address. Additionally, I've changed the form input for the sender's email address to "_replyto" so it'll make replying to any senders a lot easier and complaint, as per the Formspree doc.

Lastly, if someone is hosting their page on gh-pages, after a user sends a message through the contact me page; everything crashes. I believe this has to do with a page being hosted on gh-pages versus a registered domain name? Either way, in a similar fashion, the commented out code is my fix for proper redirection after users have used the contact me page. Once again, this applies for those hosting their site on gh-pages. So, there should be a note in either your readme or _config.yaml that tells the user that if they plan to host their site on gh-pages; then they should uncomment the fix so users will be redirected back to the site instead of crashing after sending a message.

@Cheng-Vang
Copy link
Author

I believe this should be the last issue for me. Basically, the Mailchimp newsletter wasn't working when I was testing it out. The simple fix addresses this problem so that it all works as intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant