fix: Add type/enum on string or number

[herberthobregon]

Fixed if one type a string, the other json stop working.

This is because I need to use an enum or string constants like 'hello' | 'word'
Example:

Doesn't Work

model pages {
  id         String   @id
  /// [pay_provider] 
  pay_provider    String 
  /// [ats_config] 
  ats_config          Json?
}

I dont know why Work???

model pages {
  id         String   @id
  d1    Json
  d2    String

  /// [pages.pay_provider] 
  pay_provider    String 
  /// [pages.ats_config] 
  ats_config          Json?
}

[arthurfiorette]

Hi! please add tests ensuring your change works and fixes your specific problem :)

[herberthobregon]

Perfect. I’ll work on the weekend✅

[Yesterday17]

As you've added types to number and reusing this flag, maybe we should rename this variable to somewhat like replacePrimitive?

[Yesterday17]

Maybe you should move these lines after L65

[Yesterday17]

I wonder whether these lines can be merged with the case on L104

[Yesterday17]

Thank you for the solution! I encountered the same problem recently and found this PR which fixed the problem. I left several comments and hoping to improve the code quality :)

And I have a question about the error handling logic, which might not be directly related to this PR, but I did not find a good place to ask about it. I wonder why throwOnNotFound is false only if the type is unknown? Because if findNewSignaturn does not throw, everything seems to be working too without any problem.

prisma-json-types-generator/src/helpers/find-signature.ts

Line 11 in 978d291

throwOnNotFound = true,

[herberthobregon]

Nice! At the moment I haven’t had time to finish the tests, but I find your observations valuable and I’ll review them tomorrow after work.

For now, I’m using it from my GitHub and it’s working quite well for me:

pnpm i github:herberthobregon/prisma-json-types-generator#npm

I hope to get it working as soon as possible to merge in main.