Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional GitHub Actions OIDC thumbprint #534

Merged
merged 1 commit into from
Jul 3, 2023

Conversation

lopopolo
Copy link
Member

@lopopolo lopopolo commented Jul 3, 2023

These changes are applied:

Terraform will perform the following actions:

  # module.github_actions_oidc_provider.aws_iam_openid_connect_provider.github will be updated in-place
  ~ resource "aws_iam_openid_connect_provider" "github" {
        id              = "arn:aws:iam::447522982029:oidc-provider/token.actions.githubusercontent.com"
        tags            = {}
      ~ thumbprint_list = [
            "6938fd4d98bab03faadb97b34396831e3780aea1",
          + "1c58a3a8518e8759bf075b76b750d4f2df264fcd",
        ]
        # (4 unchanged attributes hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

See: https://github.blog/changelog/2023-06-27-github-actions-update-on-oidc-integration-with-aws/
Fixes #533

These changes are applied:

```
Terraform will perform the following actions:

  # module.github_actions_oidc_provider.aws_iam_openid_connect_provider.github will be updated in-place
  ~ resource "aws_iam_openid_connect_provider" "github" {
        id              = "arn:aws:iam::447522982029:oidc-provider/token.actions.githubusercontent.com"
        tags            = {}
      ~ thumbprint_list = [
            "6938fd4d98bab03faadb97b34396831e3780aea1",
          + "1c58a3a8518e8759bf075b76b750d4f2df264fcd",
        ]
        # (4 unchanged attributes hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.
```

See: https://github.blog/changelog/2023-06-27-github-actions-update-on-oidc-integration-with-aws/
Fixes #533
@lopopolo lopopolo added A-aws Area: AWS infrastructure as code. A-github-actions Area: GitHub Actions workflows and automation. labels Jul 3, 2023
@lopopolo
Copy link
Member Author

lopopolo commented Jul 3, 2023

Verified fixed by re-running a previously failed code coverage job:

@lopopolo lopopolo merged commit 67c745d into trunk Jul 3, 2023
8 checks passed
@lopopolo lopopolo deleted the lopopolo/gha-oidc-thumbprint branch July 3, 2023 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-aws Area: AWS infrastructure as code. A-github-actions Area: GitHub Actions workflows and automation.
Development

Successfully merging this pull request may close these issues.

GitHub Actions OIDC thumbprint mismatch in code coverage jobs
1 participant