feat(publish-metrics): implement smartSampling for Playwright tracing #2453
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces two main changes:
1.
smartSampling
support for the Playwright engine tracing.If
smartSampling
is configured in the test script (as shown below), only traces that have recorded errors will be exported.2. A breaking change is introduced in the
smartSampling
configuration for the HTTP engine.The additional optional
threshold
settings will now be nested inside thehttp
key:Old config:
New config:
Testing
Tested manually by running multiple scenarios with different settings, viewing results on different observability platforms, running locally and with Fargate. All seems to be running properly. See screenshots for one of the tests below
Pre-merge checklist