[Fix] inconsistent return

.eslintrc

@@ -37,7 +37,7 @@
     "accessor-pairs": 2,
     "block-scoped-var": 2,
     "complexity": [2, 15],
-    "consistent-return": 0,
+    "consistent-return": 2,
     "curly": 2,
     "default-case": 1,
     "dot-location": 0,

Commands/init.js

@@ -25,7 +25,8 @@ var checkArtisan = function checkArtisan(cmdRes) {
   return new Promise(function promiseCheckArtisan(resolve, reject) {
     var test = cmdRes.match(/\s*Laravel\s+Framework\s+(version)?\s+(.*)/);
     if (test) {
-      return resolve(test);
+      resolve(test);
+      return;
     }
     reject(new Error('not a laravel framework'));
   });

Commands/laravelConfig.js

@@ -20,7 +20,8 @@ var prepareTmpFolder = function prepareTmpFolder() {
       unsafeCleanup: true
     }, function tmpDirCallback(err, name) {
       if (err) {
-        return reject(err);
+        reject(err);
+        return;
       }
       fs.mkdir(name + '/Config-laravel')
         .then(function tmpdirOk() {

Commands/missingJob.js

@@ -92,11 +92,13 @@ module.exports = {
     if (!app.config('app')) {
       res.red('app config missing').ln();
       res.yellow('see manual for setup config from laravel').ln();
-      return res.prompt();
+      res.prompt();
+      return;
     }
     if (Object.keys(app.config('app.job', [])).length === 0) {
       res.yellow('no job in Config/app.js').ln();
-      return res.prompt();
+      res.prompt();
+      return;
     }
     global.queueOption = {};
     Job = includeAll({

Commands/modelsCreator.js

@@ -9,7 +9,8 @@ module.exports = {
   function: function run(req, res) {
     if (app.config('core.modelsCreator.models').length === 0) {
       res.yellow('Please add models to import in Config/core.js').ln();
-      return res.prompt();
+      res.prompt();
+      return;
     }
     var dbModels = require('../lib/db-models');
     dbModels()

lib/Config.js

@@ -1,5 +1,4 @@
 'use strict';
-/* global app */
 
 var include = require('include-all');
 var fs = require('fs');
@@ -30,7 +29,7 @@ var Config = function Config(appdir, logger) {
 Config.prototype.get = function get(key, def) {
   var reduce = function reduce(obj, index) {
     if (!obj) {
-      return;
+      return null;
     }
     return obj[index];
   };

lib/Mail.js

@@ -71,12 +71,15 @@ Mail.prototype.send = function sendMail(callback) {
     self.mailer.sendMail(mailOptions, function mailerSendMail(err, info) {
       if (err) {
         if (callback) {
-          return callback(err);
+          callback(err);
+          return;
         }
-        return reject(err);
+        reject(err);
+        return;
       }
       if (callback) {
-        return callback(null, info);
+        callback(null, info);
+        return;
       }
       resolve(info);
     });

lib/db-models/lib/Model-export.js

@@ -29,13 +29,16 @@ ModelExport.prototype.createOutputDir = function createOutputDir() {
   return new Promise(function PromiseCreateOutputDir(resolve) {
     fs.stat(self.dir, function statDir(err, stats) {
       if (err || !stats.isDirectory()) {
-        return fs.mkdir(self.dir, function mkdir(mkdirErr) {
+        fs.mkdir(self.dir, function mkdir(mkdirErr) {
           if (!mkdirErr) {
-            return resolve(true);
+            resolve(true);
+            return;
           }
         });
+        return;
       }
-      return resolve(true);
+      resolve(true);
+      return;
     });
   });
 };
@@ -105,7 +108,7 @@ ModelExport.prototype.createModels = function createModels() {
           }
           //for future association
           self.associate[lowerName] = modelName;
-          return generatePromises.push(self.generateTemps({
+          generatePromises.push(self.generateTemps({
             tableName: table,
             modelName: modelName,
             fields: results[1][table]

lib/shell/lib/Shell.js

@@ -1,5 +1,4 @@
 'use strict';
-/* global app */
 /*eslint no-magic-numbers: 0 */
 
 var EventEmitter, Interface, Request, Response, shell, events, readline;
@@ -219,7 +218,7 @@ shell = (function exportShell(_super) {
     } else if (this.parent) {
       return this.parent.set(setting);
     }
-
+    return this;
   };
 
   Shell.prototype.prompt = function prompt() {

lib/shell/lib/plugins/help.js

@@ -50,7 +50,8 @@ module.exports = function help(settings) {
       var route = routes[shell.routeName[command]];
       if (!route) {
         res.red('command ' + command + ' not found');
-        return res.prompt();
+        res.prompt();
+        return;
       }
       res.yellow('Help:').ln();
       res.print(pad('', firstPad)).white(route.description).ln().ln();
@@ -90,7 +91,8 @@ module.exports = function help(settings) {
         res.ln();
       });
 
-      return res.prompt();
+      res.prompt();
+      return;
     }
     var routeText;
     res.yellow('Available commands:');
@@ -102,14 +104,16 @@ module.exports = function help(settings) {
         res.print(pad('', firstPad)).green(routeText).white(rte.description).ln();
       }
     });
-    return res.prompt();
+    res.prompt();
+    return;
   };
   console.log('add routes');
   shell.cmd('help {command(([\\w\\:])*)?}', 'Show this message', shell.help.bind(shell));
   shell.cmd('', shell.help.bind(shell));
   if (shell.isShell && settings.introduction) {
     text = typeof settings.introduction === 'string' ? settings.introduction : introduction;
-    return shell.styles.println(text);
+    shell.styles.println(text);
+    return;
   }
 };
 

lib/shell/lib/plugins/router.js

@@ -59,10 +59,10 @@ var match = function match(req, routes) {
         if ((/^\-\-/).test(arg)) {
           arg = arg.replace('--', '');
           route.options[arg] = true;
-          return;
+          return ;
         }
         if (keyArg >= keys.length) {
-          return;
+          return ;
         }
         param = keys.shift();
         key = param.key;
@@ -83,7 +83,7 @@ var match = function match(req, routes) {
       req._route_index = routeKey;
       // throw new Error('missing parameter');
       routeOk = route;
-      return false;
+      return;
     }
   });
   // console.debug('routes:',routes);
@@ -121,7 +121,7 @@ module.exports = function router(settings) {
     var args, route;
     args = Array.prototype.slice.call(arguments);
     if (!args[0]) {
-      return;
+      return this;
     }
     route = {};
     route.command = args.shift();

lib/shell/lib/routes/shellOnly.js

@@ -13,5 +13,5 @@ module.exports = function shellOnly(req, res, next) {
     res.prompt();
     return;
   }
-  return next();
+  next();
 };

lib/utils.js

@@ -41,6 +41,7 @@ module.exports = {
         return path.normalize(dir + '/..');
       }
     }
+    throw new Error('Workspace not found');
   }
 };