Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for pod level securityContext #150

Merged
merged 4 commits into from
Sep 12, 2024

Conversation

manherna
Copy link
Contributor

Hi! I have created this PR to check if addition of templating for Pod-level SecurityContext could be accepted.
I find this useful as, depending on who is using your helm Chart, they may need to define a more or less strict securityContext depending on their security policies.

Closes #149

@manherna
Copy link
Contributor Author

I found this code to be too small to make it into it's own function in securityContext package. but if you see fit, I can move it

@arttor
Copy link
Owner

arttor commented Sep 11, 2024

Hi, can you please add securityContext to one of the pods in test_data/sample-app.yaml (if it is not already exists), regenerate chart examples with

cat test_data/sample-app.yaml | go run ./cmd/helmify examples/app

cat test_data/k8s-operator-kustomize.output | go run ./cmd/helmify examples/operator

and push updated samples to your branch?

@manherna
Copy link
Contributor Author

Hi @arttor I added those samples and also changed values naming to podSecurityContext, which I think is more appropriate.

@arttor arttor merged commit 6cc1cec into arttor:main Sep 12, 2024
1 check passed
@manherna
Copy link
Contributor Author

@arttor Thanks for the supports and for this great tool!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extraction of PodSecurityContext
2 participants