Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interface(loopback): add check for same ipv4_address_secondary #28

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions pyaoscx/interface.py
Original file line number Diff line number Diff line change
Expand Up @@ -1328,7 +1328,9 @@ def configure_loopback(self, vrf, ipv4=None, description=None):
if i == 0:
self.ip4_address = ipv4[i]
else:
self.ip4_address_secondary.append(ipv4[i])
#Check if there is already the same ip4_address_secondary configured
if ipv4[i] not in self.ip4_address_secondary:
self.ip4_address_secondary.append(ipv4[i])
# If IPv4 is empty, delete
elif ipv4 == []:
self.ip4_address = None
Expand All @@ -1338,7 +1340,6 @@ def configure_loopback(self, vrf, ipv4=None, description=None):
self.description = description

# Set all remaining attributes to create a loopback

# when configuring a loopback interface, it must be powered on
self.admin_state = "up"

Expand Down