add option to send host header in HTTP proxy CONNECT command #7710
+73
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
arvidn
force-pushed
the
send-host-in-connect-option
branch
from
192958d to
13d0471
Compare
|
I've tested qBittorrent 4.6.5 with my patch (forcing send_host_in_connect to 1) but unfortunately, the issue persists. After careful investigation, I noticed that src/http_connection.cpp#590 seems never to be executed. Additionally, the condition in include/libtorrent/http_stream.hpp#132 appears to always evaluate to false. I believe understanding why these code sections are not being reached might be crucial in resolving the underlying issue. |
arvidn
force-pushed
the
send-host-in-connect-option
branch
from
13d0471 to
3b94578
Compare
|
@bearx3f are you connecting to your proxy over SSL by chance? It looks like my patch failed to take into account HTTPS proxies. |
arvidn
force-pushed
the
send-host-in-connect-option
branch
from
3b94578 to
8adc21c
Compare
|
No my proxy server only handles HTTP |
arvidn
force-pushed
the
send-host-in-connect-option
branch
from
8adc21c to
9acb255
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.