-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add converter from Turing using both Chains and Model #133
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like nice!
There are a couple of things that will break for certain models, but I provided some solutions that I'm pretty certain should work in essentially all cases:)
Co-authored-by: Tor Erlend Fjelde <[email protected]>
Thanks, @torfjelde! I love that these changes both are more general and simplify the code quite a bit. Is it possible, given a |
Causes clash with ess
These are apparently overwritten by predict
You could just call Actually, did you figure this out on your own? Looking at |
Oh, you know, I didn't realize that all I had to do was sample from the prior, then compute the log likelihood, then I would have the observed data names. It's a little awkward, but it works now! Thanks! |
This PR is a working prototype of the Turing part of the proposal in #132. With this PR, we can compute the final full
InferenceData
from the Turing example in the quickstart in a single line:It's marked draft because
false
to a group name if they don't want it to be generated.